Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move quirk url importing out of contrib into interop #2512

Merged
merged 4 commits into from
Nov 8, 2019
Merged

Move quirk url importing out of contrib into interop #2512

merged 4 commits into from
Nov 8, 2019

Conversation

Strilanc
Copy link
Contributor

@Strilanc Strilanc commented Nov 7, 2019

  • Leave exporting behind as it is not yet ready
  • Add to api.rst, fix a few documentation snags.

@Strilanc
Move quirk url importing out of contrib into interop
9755907 
- Leave exporting behind as it is not yet ready
- Add to api.rst, fix a few documentation snags.
@Strilanc Strilanc requested a review from viathor November 7, 2019 22:59
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Nov 7, 2019
viathor
viathor reviewed Nov 7, 2019
View reviewed changes
Copy link
Collaborator

@viathor viathor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This keeps cirq/contrib/quirk/url_to_circuit.py and adds cirq/interop/quirk/url_to_circuit.py and AFAICT the code ends up duplicated.

@Strilanc
Copy link
Contributor Author

Strilanc commented Nov 8, 2019

Oops. Fixed.

@Strilanc Strilanc added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 8, 2019
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 8, 2019
@CirqBot CirqBot merged commit 95a14f2 into master Nov 8, 2019
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 8, 2019
@CirqBot CirqBot deleted the quirk_toolingF branch November 8, 2019 09:45
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viathor viathor viathor approved these changes

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Strilanc @viathor @googlebot @CirqBot