Support arbitrary exponents when exporting X/Y/ZPowGate to quirk url #2513
Conversation
cirq/contrib/quirk/quirk_gate.py
Outdated
|
|
||
| if gate.global_shift == -0.5: | ||
| return QuirkOp({'id': 'R{d}}ft', 'arg': f'{gate.exponent:.4f}pi'}) |
There was a problem hiding this comment.
nit: By comparing to l.138, it seems you may have meant ^ instead of second }, i.e. 'R{d}^ft'.
What's "ft"?
There was a problem hiding this comment.
Removed the extra }.
ft is an abbreviation of "function of t".
cirq/contrib/quirk/quirk_gate.py
Outdated
| if e is None: | ||
| return None | ||
| return QuirkOp('X' + e) | ||
| def xyz_to_known(axis: str, gate: ops.EigenGate) -> QuirkOp: |
There was a problem hiding this comment.
Optional nit: "to_known" is weird, because it lacks a noun. How about "xyz_to_quirk_op"? Any ideas for better names for these functions?
(Applies to other functions below, too.)
| if e is None: | ||
| return None | ||
| return QuirkOp('X' + e) | ||
| def xyz_to_quirk_op(axis: str, gate: ops.EigenGate) -> QuirkOp: |
There was a problem hiding this comment.
Optional: Signature of this function makes it appear that it is appropriate to use it for general EigenGates, not just Pauli-PowGates. It's easy to remedy this by taking global_shift and exponent as arguments in place of the gate.
There was a problem hiding this comment.
Acknowledged, but this is a private method not exposed to users.
cirq/contrib/quirk/quirk_gate.py
Outdated
| @@ -54,9 +57,35 @@ def same_half_turns(a1: float, a2: float, atol=0.0001) -> bool: | |||
| return abs(d) < atol | |||
|
|
|||
|
|
|||
| def angle_to_exponent_key(t: Union[float, sympy.Symbol]) -> Optional[str]: | |||
| def _is_supported_formula(formula: sympy.Basic): | |||
cirq/contrib/quirk/quirk_gate.py
Outdated
| return False | ||
|
|
||
|
|
||
| def _val_to_quirk_formula(t: Union[float, sympy.Basic]) -> Optional[str]: |
There was a problem hiding this comment.
-> str
(None is never returned.)
|
|
||
| def _val_to_quirk_formula(t: Union[float, sympy.Basic]) -> Optional[str]: | ||
| if isinstance(t, sympy.Basic): | ||
| if not set(t.free_symbols) <= {sympy.Symbol('t')}: |
There was a problem hiding this comment.
Optional: This conditional is part of our validation logic, so it fits better in _is_supported_formula. I understand you've placed it here to generate more informative exceptions. An alternative that gives you both is a function _check_formula_supported that doesn't return anything but raises an exception on unsupported formulas. Up to you.
| @@ -12,6 +12,7 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| import numpy as np | |||
Strilanc
added
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
automerge
Strilanc
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
No description provided.