Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Mølmer–Sørensen gate factory #2518

Merged
merged 12 commits into from
Nov 14, 2019
Merged

Rename Mølmer–Sørensen gate factory #2518

merged 12 commits into from
Nov 14, 2019

Conversation

viathor
Copy link
Collaborator

@viathor viathor commented Nov 9, 2019 •
edited
Loading

Partially implements #2508 and #1681.

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Nov 9, 2019
@viathor viathor requested review from mlihc15, cduck and Strilanc November 9, 2019 03:00
@viathor viathor added the BREAKING CHANGE For pull requests that are important to mention in release notes. label Nov 9, 2019
Strilanc
Strilanc requested changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@Strilanc Strilanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please deprecate the old method name instead of just deleting it.

@viathor viathor added Ready for Re-Review For when reviewers take their time. and removed BREAKING CHANGE For pull requests that are important to mention in release notes. labels Nov 12, 2019
@viathor
Copy link
Collaborator Author

viathor commented Nov 12, 2019

PTAL

@Strilanc Strilanc removed the Ready for Re-Review For when reviewers take their time. label Nov 14, 2019
@viathor viathor added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 14, 2019
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 14, 2019
@CirqBot CirqBot merged commit 08df3b4 into quantumlib:master Nov 14, 2019
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlihc15 mlihc15 mlihc15 approved these changes

@Strilanc Strilanc Strilanc approved these changes

@cduck cduck Awaiting requested review from cduck

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@viathor @Strilanc @mlihc15 @googlebot @CirqBot