Fix timings for Google devices #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 1000ns is just for read-out. If we want to use this timing for non-terminal measurements, there is also a 3000ns "ring down" for signals to depopulate.
Strilanc
reviewed
Nov 11, 2019
cirq/google/devices/known_devices.py
Outdated
| @@ -201,7 +201,7 @@ def _json_dict_(self): | |||
| 'cz': 50_000, | |||
| 'xy': 20_000, | |||
| 'z': 0, | |||
| 'meas': 1_000_000, | |||
| 'meas': 4_000_000, # 1000 ms for readout, 3000ns for "ring down" | |||
There was a problem hiding this comment.
I think you're mixing up microseconds and milliseconds here. Did you mean us?
There was a problem hiding this comment.
I actually meant nano-seconds. I got it correct later in the same sentence at least...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
non-terminal measurements, there is also a 3000ns "ring down" for
signals to depopulate.