Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename iswap rotation #2526

Merged
merged 12 commits into from
Nov 13, 2019
Merged

Conversation

viathor
Copy link
Collaborator

@viathor viathor commented Nov 12, 2019

Partially fixes #2508 and #1681.

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Nov 12, 2019
@viathor viathor mentioned this pull request Nov 12, 2019
@viathor viathor requested a review from Strilanc November 12, 2019 02:31
@viathor viathor requested a review from dabacon November 13, 2019 17:07
return ISwapPowGate()**(2 * rads / pi)


@deprecated(deadline='v0.7.0', fix='Use cirq.riswap, instead.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.7 is the version this deprecation will appear in for the first time. Make it v0.8

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@Strilanc Strilanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the deprecation version

@viathor viathor merged commit 6d5087c into quantumlib:master Nov 13, 2019
@viathor viathor deleted the rename-iswap-rotation branch November 13, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming rotations
3 participants