Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pytest-changed-files include api tests when an __init__ file is changed #2575

Merged
merged 6 commits into from
Nov 21, 2019
Merged

Make pytest-changed-files include api tests when an __init__ file is changed #2575

merged 6 commits into from
Nov 21, 2019

Conversation

Strilanc
Copy link
Contributor

Fixes #2506

@Strilanc Strilanc requested a review from cduck November 20, 2019 01:01
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Nov 20, 2019
viathor
viathor approved these changes Nov 20, 2019
View reviewed changes
check/pytest-changed-files Outdated
exit 0
fi
pytest ${rest} ${changed}
pytest ${rest} ${changed[@]}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think [@] has any effect unless you place the variable in double quotes: "${changed[@]}".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored. Broke tests.

@Strilanc Strilanc added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 20, 2019
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 20, 2019
@CirqBot
Copy link
Collaborator

CirqBot commented Nov 20, 2019

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Nov 20, 2019
@Strilanc Strilanc added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 21, 2019
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 21, 2019
@CirqBot CirqBot merged commit 96f5f54 into master Nov 21, 2019
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 21, 2019
@CirqBot CirqBot deleted the changed-global branch November 21, 2019 06:50
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 21, 2019
@dstrain115 dstrain115 mentioned this pull request Nov 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viathor viathor viathor approved these changes

@cduck cduck Awaiting requested review from cduck

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include "global" tests in pytest-changed-files
4 participants
@Strilanc @CirqBot @viathor @googlebot