Fix doc build by removing tensorflow dependency #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the doc builds are failing due to running out of memory when pip installing tensorflow. I investigated fixing this problem by upgrading to the paid version of readthedocs, and found out that: 1. They do not have a way to just turn your free project into a paid project. You need to configure a new project. 2. Paid projects have *less* (**LESS!**) control over the domain name than the free projects (the URL would be prefixed with "quantum-lib-", also the top-level domain would differ). 3. The support staff does not think that this is a situation that needs to be fixed. So as a fix I'm killing off the TPU translation code from contrib and removing the tensorflow dependency. I will also look into using other documentation services.
MichaelBroughton
approved these changes
Dec 2, 2019
Strilanc
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
the
automerge
CirqBot
removed
the
front_of_queue_automerge
Strilanc
added a commit
that referenced
this pull request
Dec 3, 2019
- This is a cherry-pick from #2610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the doc builds are failing due to running out of memory when pip installing tensorflow.
I investigated fixing this problem by upgrading to the paid version of readthedocs, and found out that:
So as a fix I'm killing off the TPU translation code from contrib and removing the tensorflow dependency.
I will also look into using other documentation services.
The tpu code is in contrib, so it does not need to be deprecated. The tpu code was still slower than non-tpu simulation due to the large compile times.
As a side benefit, this will likely speed up our builds.