Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code for GCS locations since they are no longer used. #2668

Merged
merged 2 commits into from
Jan 3, 2020
Merged

Remove code for GCS locations since they are no longer used. #2668

merged 2 commits into from
Jan 3, 2020

Conversation

wcourtney
Copy link
Collaborator

No description provided.

@wcourtney wcourtney requested a review from lindmarkm January 3, 2020 19:04
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Jan 3, 2020
lindmarkm
lindmarkm approved these changes Jan 3, 2020
View reviewed changes
Copy link
Collaborator

@lindmarkm lindmarkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should look into whether it's worth it to remove the JobConfig.

@wcourtney wcourtney merged commit f306544 into quantumlib:master Jan 3, 2020
@wcourtney wcourtney deleted the gcs branch January 3, 2020 19:52
olliahonen pushed a commit to iqm-finland/Cirq that referenced this pull request Jan 10, 2020
@wcourtney @olliahonen
Remove code for GCS locations since they are no longer used. (quantum…
3b92036 
…lib#2668)

* Remove code for GCS locations since they are no longer used.
* Ran incremental format script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindmarkm lindmarkm lindmarkm approved these changes

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wcourtney @lindmarkm @googlebot