Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better decomposition of SWAP into ISWAP ** 0.5 #2682

Merged
merged 3 commits into from
Jan 16, 2020
Merged

Better decomposition of SWAP into ISWAP ** 0.5 #2682

merged 3 commits into from
Jan 16, 2020

Conversation

dstrain115
Copy link
Collaborator

  • Shortens length from 13 moments to 7 moments.
  • Decomposition courtesy of mpharrigan.

Fixes #2635

@dstrain115
Better decomposition of SWAP into ISWAP ** 0.5
dccd97a 
- Shortens length from 13 moments to 7 moments.
- Decomposition courtesy of mpharrigan.

Fixes quantumlib#2635
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Jan 15, 2020
mpharrigan
mpharrigan approved these changes Jan 15, 2020
View reviewed changes
Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mpharrigan
Copy link
Collaborator

Decomposition courtesy of mpharrigan.

I think I stole it from @john6060

@dstrain115
Copy link
Collaborator Author

I think I stole it from @john6060

Awesome, @john6060 (a.k.a. DJ Decomp) spins all of my favorite decompositions!

@dstrain115 dstrain115 merged commit de6ca2d into quantumlib:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpharrigan mpharrigan mpharrigan approved these changes

@Strilanc Strilanc Awaiting requested review from Strilanc

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need a better compilation for swap_to_sqrt_iswap
3 participants
@dstrain115 @mpharrigan @googlebot