Add get_engine and deprecate engine_from_environment #3151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabacon
changed the title
mpharrigan
approved these changes
Jul 20, 2020
| timeout: Optional[int] = None, | ||
| context: Optional[EngineContext] = None, |
There was a problem hiding this comment.
this is technically a breaking change :) any reason for the re-ordering?
There was a problem hiding this comment.
Users should not be using context directly, so moving it down helps reenforce this (also updated doc string to say this). And yeah this is technically breaking, but hopefully people aren't using context.
balopat
added
the
automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
the
automerge
balopat
added
the
automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
the
automerge
balopat
added
the
automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
the
automerge
balopat
added
the
automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
the
automerge
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
balopat
added
the
BREAKING CHANGE
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Aug 23, 2020
quantumlib#2767 introduced `get_engine_sampler`. This adds `get_engine` via a similar pattern, and in particular uses the same shared environment variable for projects, GOOGLE_PROJECT_ID. Also * deprecates `engine_from_environment` which used a different environment variable and a different nomenclature. It also fixes a bug in this methods id. * corrects a typo in the doc of `get_engine_sampler` * Gives the a sensible small string for an Engine object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2767 introduced
get_engine_sampler. This addsget_enginevia a similar pattern, and in particular uses the same shared environment variable for projects, GOOGLE_PROJECT_ID.Also
engine_from_environmentwhich used a different environment variable and a different nomenclature. It also fixes a bug in this methods id.get_engine_sampler