unleash confusion map #5717
Merged
unleash confusion map #5717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assume SimulationState subclasses accept the confusion_map argument in their `measure()` methods. Remove work around for classes that do not. This reverts commit 25388af.
Some subclasses don't need it and don't even know it.
95-martin-orion
requested changes
Jul 11, 2022
95-martin-orion
approved these changes
Jul 11, 2022
pavoljuhas
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Revert "Guard confusion_map usage (quantumlib#5534)" Assume measure() methods of SimulationState subclasses accept the `confusion_map` argument. Remove temporary workaround for methods not taking `confusion_map`. Also disable pylint check on missing argument which is required in the base class but unknown to subclasses actually called. This reverts commit 25388af.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Revert "Guard confusion_map usage (quantumlib#5534)" Assume measure() methods of SimulationState subclasses accept the `confusion_map` argument. Remove temporary workaround for methods not taking `confusion_map`. Also disable pylint check on missing argument which is required in the base class but unknown to subclasses actually called. This reverts commit 25388af.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "Guard confusion_map usage (#5534)"
Assume measure() methods of SimulationState subclasses accept the
confusion_mapargument. Remove temporary workaround for methodsnot taking
confusion_map.Also disable pylint check on missing argument which is required
in the base class but unknown to subclasses actually called.
This reverts commit 25388af.