Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

untangle entangled tests #5892

Merged
merged 3 commits into from
Sep 27, 2022

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Sep 27, 2022

  • Avoid clashing test mocks of QuantumEngineServiceClient by limiting
    mocking to the relevant test module.
  • Enable test reordering by pytest-randomly.

Fixes #5870.

@CirqBot CirqBot added the size: S 10< lines changed <50 label Sep 27, 2022
@pavoljuhas pavoljuhas added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Sep 27, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Sep 27, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented Sep 27, 2022

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Sep 27, 2022
@pavoljuhas pavoljuhas added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Sep 27, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Sep 27, 2022
@CirqBot CirqBot merged commit 2575da7 into quantumlib:master Sep 27, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Sep 27, 2022
@pavoljuhas pavoljuhas deleted the untangle-entangled-tests branch September 27, 2022 20:41
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
- Avoid clashing test mocks of QuantumEngineServiceClient by limiting
  mocking to the relevant test module.
- Enable test reordering by pytest-randomly.

Fixes quantumlib#5870.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix inter-dependency of tests in engine_client_test.py
3 participants