Override gate.controlled() for GlobalPhaseGate to return a ZPowGate #6073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstrain115
approved these changes
May 9, 2023
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…uantumlib#6073) * Override gate.controlled() for GlobalPhaseGate to return a ZPowGate * Test unitary equivalence * Override controlled only if gate is not parameterized * Fix typo * Fix type check * another attempt at fixing types * Add a comment and additional tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZPowGate,CZPowGateandCCZPowGatecurrently have specializedGate.controlled()overrides such thatcirq.Z.controlled()returns acirq.CZinstead of acirq.ControlledGate(sub_gate=cirq.Z). This is nice and useful for writing controlled versions of common gates.This PR extends the same idea to
GlobalPhaseGate, because a controlledGlobalPhaseGateis equivalent to applying acirq.ZPowGate.