v0.3 API + debiasing #6077
Merged
v0.3 API + debiasing #6077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new version of the API separates job status and metadata from actual results into two different endpoints. v0.3 also includes support for error_mitigation settings like symmetrization as described in https://arxiv.org/pdf/2301.07233.pdf Because of that: - added a new error_mitigation parameter on job submission so users can configure it - added a new aggregation parameter on results that would allow getting results aggregated under the two different methods described in the paper. Averaging and Plurality voting
splch
requested review from
dabacon,
ColemanCollins,
nakardo,
gmauricio,
a team,
vtomole and
cduck
as code owners
splch
force-pushed
the
mm/feat/v0.3-and-symmetrization
branch
from
e017a25 to
11853ab
Compare
dstrain115
reviewed
Apr 24, 2023
cirq-ionq/cirq_ionq/job.py
Outdated
| @@ -65,6 +65,8 @@ class Job: | |||
| 'data associated with it beyond an id and a status.', | |||
| ) | |||
|
|
|||
| SUPPORTED_AGGREGATIONS = {'average', 'plurality'} | |||
There was a problem hiding this comment.
Can we document these somewhere? Maybe lower down on line 186?
cirq-ionq/cirq_ionq/service.py
Outdated
| @@ -100,12 +101,15 @@ def run( | |||
| seed: If the target is `simulation` the seed for generating results. If None, this | |||
| will be `np.random`, if an int, will be `np.random.RandomState(int)`, otherwise | |||
| must be a modulate similar to `np.random`. | |||
| error_mitigation: error mitigation settings | |||
There was a problem hiding this comment.
This requires more explanation. What are the keys and the values of this dictionary?
cirq-ionq/cirq_ionq/service.py
Outdated
| @@ -141,14 +146,15 @@ def create_job( | |||
| repetitions: The number of times to repeat the circuit. Defaults to 100. | |||
| name: An optional name for the created job. Different from the `job_id`. | |||
| target: Where to run the job. Can be 'qpu' or 'simulator'. | |||
| error_mitigation: Error mitigation settings | |||
There was a problem hiding this comment.
Same here, or reference the other setting.
I included some details about the new parameters |
senecameeks
added
the
triage/accepted
|
thanks for the help @dstrain115 |
dstrain115
approved these changes
May 19, 2023
Closed
Great updated those and ensured tests are accurate :) |
auto-merge was automatically disabled
August 2, 2023 17:54
Head branch was pushed to by a user without write access
splch
force-pushed
the
mm/feat/v0.3-and-symmetrization
branch
from
993a6d0 to
f7907fe
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6077 +/- ##
========================================
Coverage 97.87% 97.88%
========================================
Files 1106 1106
Lines 95589 95710 +121
========================================
+ Hits 93561 93683 +122
+ Misses 2028 2027 -1
☔ View full report in Codecov by Sentry. |
|
@tanujkhattar i made an additional pr to update tests and it disabled auto-merge, can that be resolved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new version of the API separates job status and metadata from actual results into two different endpoints.
v0.3 also includes support for error_mitigation settings like symmetrization as described in https://arxiv.org/pdf/2301.07233.pdf
This includes:
continues #6007