GridDevice serialization refactor #6094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verult
force-pushed
the
cg-device-refactor/griddevice-serialization-by-serializing-gateset
branch
from
3aa0c24 to
3cf2d1d
Compare
verult
force-pushed
the
cg-device-refactor/griddevice-serialization-by-serializing-gateset
branch
from
9910c79 to
4837660
Compare
dstrain115
reviewed
May 16, 2023
| """GateFamilies which match all other valid gate representations.""" | ||
| additional_forms: List[cirq.GateFamily] = field(default_factory=list) | ||
| """`primary_forms` (as GateFamilies) + `additional_forms`""" | ||
| all_forms: List[cirq.GateFamily] = field(init=False) |
There was a problem hiding this comment.
Optional: Should this be a generated @Property instead? I guess, with init=False, they can't specify it, so maybe that's okay.
| """The name of gate type in `GateSpecification`.""" | ||
| gate_spec_name: str | ||
| """Gate representations to be included in generated gatesets and gate durations.""" | ||
| primary_forms: List[GateOrFamily] |
There was a problem hiding this comment.
The primary and additional forms definition is kind of confusing to me. This new terminology is not explained very clearly by these docstrings. Maybe the class docstring could give more context as to what's going on here?
maffoo
reviewed
May 16, 2023
verult
commented
May 17, 2023
|
In the latest push:
|
Gateset.gates is a collection of GateFamilies, so most branches in the check don't apply.
maffoo
approved these changes
May 17, 2023
verult
added
the
automerge
…factor/griddevice-serialization-by-serializing-gateset
verult
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor adds the
to_proto()method to serializeGridDeviceintoDeviceSpecification. The convenience method to create aDeviceSpecificationfrom partial gateset information,_create_device_specification_proto(), is also reimplemented asGridDevice.from_device_information()and returns aGridDeviceinstead. These features makes using server-side GridDevice viable - Server-side and client-side GridDevice instances should now be identical.In addition, gateset serialization and deserialization mappings are reorganized into a shared data structure.
cc @maffoo @pavoljuhas