Support serialization of cirq-google.CouplerPulse gate #6472
Conversation
NoureldinYosri
requested review from
wcourtney,
vtomole,
cduck,
verult and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6472 +/- ##
==========================================
- Coverage 97.75% 97.74% -0.02%
==========================================
Files 1105 1105
Lines 94909 94925 +16
==========================================
Hits 92783 92783
- Misses 2126 2142 +16 ☔ View full report in Codecov by Sentry. |
| } | ||
|
|
||
| message CouplerPulseGate{ | ||
| optional FloatArg hold_time_ps = 1; |
There was a problem hiding this comment.
Please add line comments. ps=pico seconds? Do we foresee a need for sub-nanosecond timing?
There was a problem hiding this comment.
added. initially I was using ns, but when I wrote a test that used ps I got precision error. the test input was cirq.Duration(picos=1) and when the object got translated it had cirq.Duration(nanos=1.0000000..1e-3). so I'm using ps to avoid that.
| @@ -22,6 +22,7 @@ def test_docker_stable(): | |||
| assert result.returncode == 0 | |||
|
|
|||
|
|
|||
| @pytest.mark.skip(reason="fails due to boken dependendencies #6475") | |||
There was a problem hiding this comment.
fyi - it is better to submit a separate tiny PR with this change only so that we keep a single topic per PR.
first step to fix #6440
cc: @eliottrosenberg