Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin scipy to ~1.12.0 to temporarily fix ci #6545

Merged
merged 1 commit into from
Apr 2, 2024
Merged

pin scipy to ~1.12.0 to temporarily fix ci #6545

merged 1 commit into from
Apr 2, 2024

Conversation

NoureldinYosri
Copy link
Collaborator

context: #6543

@NoureldinYosri NoureldinYosri requested review from vtomole, cduck and a team as code owners April 2, 2024 22:37
@codecov Codecov
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (f955650) to head (426de3c).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6545   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files        1107     1107           
  Lines       95182    95182           
=======================================
  Hits        93073    93073           
  Misses       2109     2109

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pavoljuhas
pavoljuhas approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NoureldinYosri NoureldinYosri merged commit acb7bf8 into quantumlib:main Apr 2, 2024
31 checks passed
@BichengYing
Copy link
Collaborator

@NoureldinYosri @pavoljuhas I have a conflict of using cirq with pyle on scipy version. Can we just modify it into scipy < 1.13?

  SolverProblemError

  Because pyle depends on cirq-core (1.4.0.dev20240404120310) which depends on scipy (>=1.12.0,<1.13.0), scipy is required.
  So, because pyle depends on scipy (~1.9.2), version solving failed.

@BichengYing BichengYing mentioned this pull request Apr 4, 2024
Merged
pavoljuhas pushed a commit that referenced this pull request Apr 4, 2024
@BichengYing
Loosen the scipy condition in requirements.txt (#6549)
9ab6601 
In order to avoid the conflict of requirement specs for packages that need older scipy
just require that scipy is pinned to versions before 1.13.

For previous context for scipy ~=1.12 see #6545 and #6543
jselig-rigetti pushed a commit to jselig-rigetti/Cirq that referenced this pull request May 28, 2024
@NoureldinYosri @jselig-rigetti
pin scipy to ~1.12.0 to temporarily fix ci (quantumlib#6545)
cff979a
jselig-rigetti pushed a commit to jselig-rigetti/Cirq that referenced this pull request May 28, 2024
@BichengYing @jselig-rigetti
Loosen the scipy condition in requirements.txt (quantumlib#6549)
c16a244 
In order to avoid the conflict of requirement specs for packages that need older scipy
just require that scipy is pinned to versions before 1.13.

For previous context for scipy ~=1.12 see quantumlib#6545 and quantumlib#6543
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@NoureldinYosri
pin scipy to ~1.12.0 to temporarily fix ci (quantumlib#6545)
f0dca6b
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@BichengYing
Loosen the scipy condition in requirements.txt (quantumlib#6549)
be9b72c 
In order to avoid the conflict of requirement specs for packages that need older scipy
just require that scipy is pinned to versions before 1.13.

For previous context for scipy ~=1.12 see quantumlib#6545 and quantumlib#6543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@cduck cduck Awaiting requested review from cduck

@dabacon dabacon Awaiting requested review from dabacon dabacon is a code owner automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoureldinYosri @BichengYing @pavoljuhas