Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maintainer and maintainer_email fields to setup.py #6887

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Dec 28, 2024

The setup.py files (at the top level as well as the various Cirq modules) currently define the author and author_email fields. The set of authors of Cirq, and the set of maintainers of Cirq at any given time, are somewhat overlapping but not identical. The Python Packaging User Guide defines maintainer and maintainer_email fields to identify the maintainer contact info. This PR adds the values to the setup.py files.

@CirqBot CirqBot added the size: S 10< lines changed <50 label Dec 28, 2024
This is to match the chances done to the top-level setup.py file.
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (686766f) to head (5c964d1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6887   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files        1084     1084           
  Lines       94225    94225           
=======================================
  Hits        92215    92215           
  Misses       2010     2010           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhucka mhucka marked this pull request as ready for review December 28, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants