Add SymmetricBanded matrix block encoding
#1177
Merged
+274
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
approved these changes
Jul 26, 2024
Collaborator
mpharrigan
left a comment
mpharrigan
left a comment
There was a problem hiding this comment.
A couple of things, but lgtm after fixing them
Comment on lines
+319
to
+321
| is_symbolic(self.bandsize) | ||
| or is_symbolic(self.system_bitsize) | ||
| or is_symbolic(self.num_nonzero) |
Collaborator
There was a problem hiding this comment.
we should probably keep this check for now, but it's interesting that I think this method would still work for symbolic values (except for the check, which can be ignored for symbolic)
Contributor
Author
There was a problem hiding this comment.
You're right that it would still work. Is it expected that we would ever call_classically a bloq with symbolic attributes but concrete ClassicalValT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add row and column oracles to block encode a symmetric banded matrix. The symmetry here refers to the pattern of non-zero entries, not necessarily the entries themselves, which are determined separately by the entry oracle.