Refactor phase gradient bloq dtypes#1191
Merged
anurudhp merged 7 commits intoquantumlib:mainfrom Jul 26, 2024
Merged
Conversation
mpharrigan
approved these changes
Jul 26, 2024
Collaborator
mpharrigan
left a comment
mpharrigan
left a comment
There was a problem hiding this comment.
this lgtm. the library changes seem minimal and the test changes -- splitting into more specific unit tests is always appreciated
mpharrigan
reviewed
Jul 26, 2024
| @pytest.mark.parametrize( | ||
| 'bloq', | ||
| [ | ||
| pytest.param(bloq, marks=pytest.mark.slow if bloq.num_qubits() > 12 else ()) |
Collaborator
There was a problem hiding this comment.
bloq2 is still getting executed on my machine (7 seconds) despite it looking like it should be 4+9=13 qubits
Collaborator
There was a problem hiding this comment.
consider using bloq.signature.n_qubits, which is explicit about how it handles left/right registers
Contributor
Author
There was a problem hiding this comment.
About bloq2, my guess would be that because AddIntoPhaseGrad doesn't define a decomposition, but only a classical action, and cirq.unitary is much faster for classical gates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
splitting #1142, part 1.
dtypeproperties to all bloqs and use them in signatures