Use QDType bit interfaces for classical simulation#1215
Merged
anurudhp merged 5 commits intoquantumlib:mainfrom Jul 31, 2024
Merged
Use QDType bit interfaces for classical simulation#1215anurudhp merged 5 commits intoquantumlib:mainfrom
anurudhp merged 5 commits intoquantumlib:mainfrom
Conversation
Collaborator
|
Since this will close all those bugs, can you open a bug for classical simulation of fixed point. A brief overview of the current situation where you pass around ints because of deficiencies in fxpmath; and potential alternatives going forward |
This was referenced Jul 30, 2024
Contributor
Author
Done! |
mpharrigan
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final part of #1142!
ints_to_bitsandbits_to_ints, and always use QDType bit interfaces (from_bits, to_bitsetc.).Fixes #811
Fixes #606
Fixes #643