Skip to content

Support symbolic CtrlSpec #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpharrigan merged 2 commits into from
Nov 11, 2024
Merged

Support symbolic CtrlSpec #1491

mpharrigan merged 2 commits into from
Nov 11, 2024

Conversation

@anurudhp
Copy link
Contributor

@anurudhp anurudhp commented Nov 9, 2024 •
edited
Loading

  • update element type of CtrlSpec.cvs from NDArray to Union[NDArray, Shaped]
  • add tests for symbolic ctrl-specs
  • move some qualtran.symbolics code to more appropriate files.

fixes #1168

@anurudhp anurudhp mentioned this pull request Nov 10, 2024
Merged
@anurudhp
Copy link
Contributor Author

anurudhp commented Nov 10, 2024

@mpharrigan @fdmalone ptal

@anurudhp anurudhp mentioned this pull request Nov 11, 2024
Merged
mpharrigan
mpharrigan approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@mpharrigan mpharrigan merged commit 179396d into quantumlib:main Nov 11, 2024
@anurudhp anurudhp deleted the 2024/11/06-symb-ctrlspec branch November 11, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpharrigan mpharrigan mpharrigan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CtrlSpec add support for symbolic Shaped control values

2 participants

@anurudhp @mpharrigan