Fix RowColumnOracle Signature
#1780
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The row and column oracle are defined as such (Lin Lin (2022). Ch. 6.5.):
$O_c\ket{\ell}\ket{j}=\ket{c(j, \ell)}\ket{j}$ , where $c(j,\ell)$ gives the $\ell$ -th non zero entry in the $j$ -th column.
So indeed, in input the value of l is bounded by the number of non zero entries in the matrix. But in output, the value of$c(j,\ell)$ is unbounded as the $\ell$ -th non zero entry can be anywhere in the column.
So the Signature of
RowColumnOracleis incorrect and that was makingassert_consistent_classical_actionthrowing errors it should not have.This is fixed by this PR.