Conversation
mpharrigan
reviewed
May 2, 2023
mpharrigan
reviewed
May 8, 2023
mpharrigan
requested changes
May 8, 2023
Collaborator
mpharrigan
left a comment
mpharrigan
left a comment
There was a problem hiding this comment.
- nits
- use multidimensional registers where appropriate. Use right-registers where appropriate
- make sure the register docstrings match reality
Co-authored-by: Matthew Harrigan <mpharrigan@google.com>
6 tasks
mpharrigan
reviewed
May 10, 2023
…aFermionGate` and `ApplyGateToLthQubit` (#210) * Fix numerical instability issue in and_gate.ipynb * Remove prints * Add SelectionRegisters and multi-indexed versions of SelectedMajoranaFermionGate and ApplyGateToLthQubit * Add a SelectionRegister base class and use it in SelectionRegisters derived class
Collaborator
Author
|
@mpharrigan I think I addressed your comments. PTAL |
Collaborator
|
thanks @fdmalone sorry for the delay! |
mpharrigan
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding some bloqs primitives from #153. Draft for the moment to see if this level of simply documenting costs is sufficient?