Fix coefficient type for GlobalPhase, and convert from cirq correctly
#901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anurudhp
changed the title
GlobalPhase, and convert from cirq correctlyGlobalPhase, and convert from cirq correctly
mpharrigan
reviewed
Apr 26, 2024
Comment on lines
52
to
56
| coefficient = ( | ||
| sympy.conjugate(self.coefficient) | ||
| if is_symbolic(self.coefficient) | ||
| else complex(self.coefficient).conjugate() | ||
| ) |
There was a problem hiding this comment.
worth adding as a helper function to symbolic_counting_utils?
There was a problem hiding this comment.
moved it there, and added a new type alias SymbolicComplex
mpharrigan
approved these changes
Apr 26, 2024
anurudhp
force-pushed
the
2024-04-fix-gphase-cirq-to-bloq
branch
from
e0683f4
to
94d53b1
Compare
anurudhp
force-pushed
the
2024-04-fix-gphase-cirq-to-bloq
branch
from
94d53b1
to
5f3bf9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gate now supports symbolic phase coefficients.
The
_cirq_gate_to_bloqwas changed in #891 to only considerfloat|complex. This PR fixes the type inGlobalPhase, so that everycirq.GlobalPhaseGatecan be converted to it.