Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QCQMC Part 4 #346

Merged
merged 6 commits into from
Jun 19, 2024
Merged

QCQMC Part 4 #346

merged 6 commits into from
Jun 19, 2024

Conversation

fdmalone
Copy link
Collaborator

Adds the shadow tomography module.

Depends on #342 and #343

@fdmalone
Copy link
Collaborator Author

cc @mpharrigan

cc @wjhuggins: 7f5ae44#diff-413ef535e04fd816dbfef4b013ff25cf7b923daf4ab6ef74832b66977f2a0ff9R35 etc, there are a bunch of ????? in the docstrings. Please advise

@wjhuggins
Copy link

I don't know why they don't appear here, but I added inline comments in the file at the link to the diff. Would you like me to draft some new docstrings? How much detail should we add to the shadow tomography piece? One option would be to go light on the detail but add a demo notebook that explains things a bit more. I could whip that up.

@fdmalone
Copy link
Collaborator Author

Examples are probably better. I'll tag you in an issue. It can go in after everything else is merged.

@fdmalone
Copy link
Collaborator Author

@mpharrigan / @wjhuggins PTAL

@mpharrigan mpharrigan merged commit c81a9db into quantumlib:master Jun 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants