Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QCQMC notebook refactor #356

Merged
merged 40 commits into from
Jul 12, 2024
Merged

Conversation

fdmalone
Copy link
Collaborator

@fdmalone fdmalone commented Jul 1, 2024

Adds some utility functions for interacting with the AFQMC code ipie and tidies up some things.

Depends on #355

@fdmalone fdmalone mentioned this pull request Jul 1, 2024
@fdmalone fdmalone requested review from mpharrigan and dstrain115 July 1, 2024 23:11
Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but seems fine to me.

conftest.py Show resolved Hide resolved
docs/qcqmc/index.md Outdated Show resolved Hide resolved
recirq/qcqmc/convert_to_ipie.py Show resolved Hide resolved
recirq/qcqmc/convert_to_ipie.py Outdated Show resolved Hide resolved
recirq/qcqmc/fqe_conversion.py Outdated Show resolved Hide resolved
recirq/qcqmc/fqe_conversion.py Outdated Show resolved Hide resolved
@fdmalone
Copy link
Collaborator Author

Somehow the "previous" cirq version is causing a breakage of the CI and it fails to install numpy (going back to 1.19.x)

@dstrain115
Copy link
Collaborator

Somehow the "previous" cirq version is causing a breakage of the CI and it fails to install numpy (going back to 1.19.x)

FYI: this is installing cirq 1.1, which is from 2022 and probably has quite old dependencies. We probably need to upgrade cirq dependencies in ReCirq.

@fdmalone fdmalone mentioned this pull request Jul 12, 2024
@mpharrigan
Copy link
Collaborator

Sorry. The previous, current, next thing was set up before cirq reached 1.0 and there were more version compatibility concerns

@fdmalone
Copy link
Collaborator Author

It's weird that I couldn't merge master into this branch on the website following #358, fingers crossed.

@fdmalone fdmalone merged commit a433644 into quantumlib:master Jul 12, 2024
5 checks passed
@fdmalone fdmalone deleted the qcqmc-notebook-refactor branch July 12, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants