-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QCQMC notebook refactor #356
QCQMC notebook refactor #356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits, but seems fine to me.
Somehow the "previous" cirq version is causing a breakage of the CI and it fails to install numpy (going back to 1.19.x) |
FYI: this is installing cirq 1.1, which is from 2022 and probably has quite old dependencies. We probably need to upgrade cirq dependencies in ReCirq. |
Sorry. The previous, current, next thing was set up before cirq reached 1.0 and there were more version compatibility concerns |
It's weird that I couldn't merge master into this branch on the website following #358, fingers crossed. |
Adds some utility functions for interacting with the AFQMC code ipie and tidies up some things.
Depends on #355