Build: allow offline build using system libraries #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewrisinger
changed the title
drewrisinger
added a commit
to drewrisinger/nur-packages
that referenced
this pull request
Mar 3, 2022
Defaults to pre-installed version of pybind11. The search was refactored to a cmake module. Will default to using the system pybind11, and fetch pybind11 via git if it is not installed
drewrisinger
commented
Mar 8, 2022
95-martin-orion
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR is to support offline build using a system like https://nixos.org/, which does not support buildtime network access. This prevents the current system of fetching a specific version of pybind11 via git.
Essentially, this refactors the pybind11 library search process (via cmake) to a module, and then sets that module to default to the system pybind11 library. This will only change your build process if you also have pybind11 libraries installed on the path.
I'm also open to a flag to switch behavior between system library vs specified pybind11 version.