Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cuda enabled - SimulatorCUDA #596

Merged
merged 28 commits into from
Apr 12, 2023
Merged

Cuda enabled - SimulatorCUDA #596

merged 28 commits into from
Apr 12, 2023

Conversation

jaeyoo
Copy link
Contributor

@jaeyoo jaeyoo commented Mar 19, 2023

This PR enables tensor injection into SimulatorCUDA. (a tensor from TFQ context)

sergeisakov
sergeisakov reviewed Mar 31, 2023
View reviewed changes
lib/simulator_cuda.h Outdated Show resolved Hide resolved
@jaeyoo
Copy link
Contributor Author

jaeyoo commented Mar 31, 2023

macosx numpy versions : 1.21.0, 1.21.1, 1.21.2, 1.21.3, 1.21.4, 1.21.5, 1.21.6
manylinux numpy versions: 1.21.0, 1.21.1, 1.21.2, 1.21.3, 1.21.4, 1.21.5, 1.21.6
windows numpy versions : 1.21.0, 1.21.1, 1.21.2, 1.21.3, 1.21.4, 1.21.5, 1.21.6

Let me try 1.21.6.

@jaeyoo
Copy link
Contributor Author

jaeyoo commented Mar 31, 2023 •
edited
Loading

numpy failed at ubuntu/windows with error messages:
1.21.0, 1.21.1, 1.22.0, 1.22.1, 1.22.2, 1.22.3, 1.22.4, 1.23.0rc1, 1.23.0rc2, 1.23.0rc3, 1.23.0, 1.23.1, 1.23.2, 1.23.3, 1.23.4, 1.23.5, 1.24.0rc1, 1.24.0rc2, 1.24.0, 1.24.1, 1.24.2

mac success with 1.21.6

let me try 1.21.1

@jaeyoo
Copy link
Contributor Author

jaeyoo commented Mar 31, 2023

compile error : NumPy 1.21.1 may not yet support Python 3.11

@jaeyoo
Copy link
Contributor Author

jaeyoo commented Mar 31, 2023

roll back to the original numpy setup (numpy~=1.16)

This was referenced Mar 31, 2023
Closed
Closed
@95-martin-orion 95-martin-orion added the kokoro:run Trigger Kokoro builds for this PR. label Apr 3, 2023
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Apr 3, 2023
@95-martin-orion 95-martin-orion added the kokoro:run Trigger Kokoro builds for this PR. label Apr 4, 2023
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Apr 5, 2023
@95-martin-orion 95-martin-orion added the kokoro:run Trigger Kokoro builds for this PR. label Apr 12, 2023
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Apr 12, 2023
95-martin-orion
95-martin-orion requested changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinging @sergeisakov to confirm that simmux.h changes look OK.

.bazelrc Show resolved Hide resolved
WORKSPACE Show resolved Hide resolved
build_tools/test_libs.sh Show resolved Hide resolved
sergeisakov
sergeisakov requested changes Apr 12, 2023
View reviewed changes
lib/simmux.h Outdated Show resolved Hide resolved
@jaeyoo jaeyoo requested a review from sergeisakov April 12, 2023 20:25
sergeisakov
sergeisakov reviewed Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@sergeisakov sergeisakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please wait for @95-martin-orion's approval.

@95-martin-orion 95-martin-orion merged commit d747970 into quantumlib:master Apr 12, 2023
@jaeyoo jaeyoo mentioned this pull request Apr 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeisakov sergeisakov sergeisakov approved these changes

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaeyoo @95-martin-orion @sergeisakov @qsim-qsimh-bot