Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set PYTHON_INCLUDE_DIR in setup.py and pass it to CMake #647

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Set PYTHON_INCLUDE_DIR in setup.py and pass it to CMake #647

merged 3 commits into from
Jan 26, 2024

Conversation

basnijholt
Copy link
Contributor

Prevents

CMake Error at /home/bas.nijholt/micromamba/envs/qsim/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find PythonLibs (missing: PYTHON_INCLUDE_DIRS) (Required is at
  least version "3.7")
Call Stack (most recent call first):
  /home/bas.nijholt/micromamba/envs/qsim/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  /home/bas.nijholt/micromamba/envs/qsim/share/cmake-3.27/Modules/FindPythonLibs.cmake:323 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  pybind_interface/cuda/CMakeLists.txt:18 (find_package)

@basnijholt
Set PYTHON_INCLUDE_DIR in setup.py
34cab62 
Prevents
```
      CMake Error at /home/bas.nijholt/micromamba/envs/qsim/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
        Could NOT find PythonLibs (missing: PYTHON_INCLUDE_DIRS) (Required is at
        least version "3.7")
      Call Stack (most recent call first):
        /home/bas.nijholt/micromamba/envs/qsim/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
        /home/bas.nijholt/micromamba/envs/qsim/share/cmake-3.27/Modules/FindPythonLibs.cmake:323 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
        pybind_interface/cuda/CMakeLists.txt:18 (find_package)
```
@basnijholt basnijholt changed the title Set PYTHON_INCLUDE_DIR in setup.py Set PYTHON_INCLUDE_DIR in setup.py and pass it to CMake Dec 6, 2023
basnijholt added a commit to basnijholt/qsimcirq-feedstock that referenced this pull request Dec 7, 2023
@basnijholt
Enable CUDA builds and apply patches from https://github.com/quantuml…
0b778d6 
…ib/qsim

- quantumlib/qsim#645
- quantumlib/qsim#646
- quantumlib/qsim#647
- quantumlib/qsim#649
@basnijholt basnijholt mentioned this pull request Dec 7, 2023
Merged
5 tasks
basnijholt added a commit to basnijholt/qsimcirq-feedstock that referenced this pull request Dec 7, 2023
@basnijholt
Enable CUDA builds and apply patches from https://github.com/quantuml…
9f8f29e 
…ib/qsim

- quantumlib/qsim#645
- quantumlib/qsim#646
- quantumlib/qsim#647
- quantumlib/qsim#649
@NoureldinYosri NoureldinYosri added the kokoro:run Trigger Kokoro builds for this PR. label Jan 25, 2024
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Jan 25, 2024
@NoureldinYosri NoureldinYosri added the kokoro:run Trigger Kokoro builds for this PR. label Jan 25, 2024
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Jan 25, 2024
@NoureldinYosri NoureldinYosri merged commit 3bdec77 into quantumlib:master Jan 26, 2024
17 checks passed
basnijholt added a commit to basnijholt/qsimcirq-feedstock that referenced this pull request Jan 30, 2024
@basnijholt
rm patch: quantumlib/qsim#647
8630309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoureldinYosri NoureldinYosri NoureldinYosri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basnijholt @NoureldinYosri @qsim-qsimh-bot