Skip to content

Fix #935: avoid the need to deallocate an object #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 4, 2025
Merged

Fix #935: avoid the need to deallocate an object #937

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a66856
Fix #935: avoid the need to dealocate an object
mhucka Nov 4, 2025
af7ba57
Merge branch 'quantumlib:main' into mh-fix-935
mhucka Nov 4, 2025
67cfdae
Implement better approach from Sergei
mhucka Nov 4, 2025
49231db
Merge branch 'main' into mh-fix-935
mhucka Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions lib/gate_appl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,16 @@ template <typename Simulator, typename Gate, typename Rgen>
inline bool ApplyGate(const typename Simulator::StateSpace& state_space,
const Simulator& simulator, const Gate& gate, Rgen& rgen,
typename Simulator::State& state) {
using MeasurementResult = typename Simulator::StateSpace::MeasurementResult;
std::vector<MeasurementResult> discarded_results;
return
ApplyGate(state_space, simulator, gate, rgen, state, discarded_results);
if (gate.kind == gate::kMeasurement) {
auto measure_result = state_space.Measure(gate.qubits, rgen, state);
if (!measure_result.valid) {
return false;
}
} else {
ApplyGate(state_space, simulator, gate);
}

return true;
}

/**
Expand Down Expand Up @@ -220,10 +226,16 @@ template <typename Simulator, typename Gate, typename Rgen>
inline bool ApplyFusedGate(const typename Simulator::StateSpace& state_space,
const Simulator& simulator, const Gate& gate,
Rgen& rgen, typename Simulator::State& state) {
using MeasurementResult = typename Simulator::StateSpace::MeasurementResult;
std::vector<MeasurementResult> discarded_results;
return ApplyFusedGate(
state_space, simulator, gate, rgen, state, discarded_results);
if (gate.kind == gate::kMeasurement) {
auto measure_result = state_space.Measure(gate.qubits, rgen, state);
if (!measure_result.valid) {
return false;
}
} else {
ApplyFusedGate(simulator, gate, state);
}

return true;
}

} // namespace qsim
Expand Down
Loading