Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated saltelli with sobol SALib 1.4.6+. #211

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Replace deprecated saltelli with sobol SALib 1.4.6+. #211

merged 2 commits into from
Oct 28, 2022

Conversation

quaquel
Copy link
Owner

@quaquel quaquel commented Oct 28, 2022 •
edited by EwoutH
Loading

Replace deprecated saltelli with sobol SALib 1.4.6+. Behind the scenes the Sobol method will call SciPy scipy.stats.qmc.Sobol.

Fixes:

DeprecationWarning: salib.sample.saltelli will be removed in SALib 1.5. Please use salib.sample.sobol

Part of #201.

@quaquel quaquel requested a review from EwoutH October 28, 2022 13:15
@coveralls
Copy link

coveralls commented Oct 28, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 81.139% when pulling 9385b51 on salib into ff21348 on master.

@EwoutH EwoutH changed the title Salib Replace deprecated saltelli with sobol SALib 1.4.6+. Oct 28, 2022
@EwoutH EwoutH added this to the 2.3.0 milestone Oct 28, 2022
@EwoutH EwoutH merged commit 6deab9c into master Oct 28, 2022
@EwoutH
Copy link
Collaborator

EwoutH commented Oct 28, 2022

Cleaned up and merged!

We might have to keep an eye on that the change in sampler back-end doesn't introduce unexpected behaviour.

@quaquel quaquel deleted the salib branch October 28, 2022 13:37
@EwoutH EwoutH mentioned this pull request Nov 1, 2022
Open
12 tasks
@EwoutH EwoutH removed their request for review April 19, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependency maintenance
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@quaquel @coveralls @EwoutH