Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes a bug where Prim modifies the experiments array #228

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Conversation

quaquel
Copy link
Owner

@quaquel quaquel commented Mar 5, 2023

x (the experiments) is modified inside the Prim class. This is an unintended side effect. The fix is to copy x before making any changes.

@quaquel quaquel requested a review from EwoutH March 5, 2023 03:44
@quaquel quaquel added the bug label Mar 5, 2023
@quaquel quaquel merged commit b003ee1 into master Mar 5, 2023
@quaquel quaquel deleted the bugfix_prim branch October 31, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants