Fix pretty print for RealParameter and IntegerParameter #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwoutH
changed the title
EwoutH
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Looks like a useful improvement to make prints more readable!
For the label, is it a bugfix or enhancement?
PS: I'm sometimes also to lazy, tired or time-limited to write a commit message. Here's my solution:
Put .diff after the GitHub URL of your PR or commit message (i.e. https://github.com/quaquel/EMAworkbench/pull/255.diff, throw it in ChatGPT and ask to write a commit message and quickly check if it's correct. Works amazing about 85% of the time for me!
|
It's a bug fix, because this used to work fine in the past. And it did still work fine for some Parameter classes (e.g. categorical) |
EwoutH
changed the title
BooleanParameter.__repr__ added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the string representation of RealParameter and IntegerParameter instances by adding a
__repr__()method to both classes. The new representation includes all relevant information about the parameters, such as name, lower and upper bounds, resolution, default value, variable name, and pff status.Changes:
__repr__()method to RealParameter class__repr__()method to IntegerParameter class