Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #274 Make all Variable subclasses name valid python identifiers #307

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ema_workbench/em_framework/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,7 @@ def variable_name(self, name):

def __init__(self, name):
if not name.isidentifier():
DeprecationWarning(
f"'{name}' is not a valid Python identifier. Starting from version 3.0 of the EMAworkbench, names must be valid python identifiers"
)
raise ValueError(f"'{name}' is not a valid Python identifier.")
super().__init__(name)


Expand Down
Loading