Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Switch default jobs to Python 3.12 #314

Merged
merged 2 commits into from
Nov 17, 2023
Merged

CI: Switch default jobs to Python 3.12 #314

merged 2 commits into from
Nov 17, 2023

Conversation

EwoutH
Copy link
Collaborator

@EwoutH EwoutH commented Nov 17, 2023

Add Python 3.12 to CI testing by switching all default jobs to 3.12. Python 3.9 to 3.11 is still tested.

@coveralls
Copy link

coveralls commented Nov 17, 2023

Coverage Status

coverage: 80.217% (-0.4%) from 80.578%
when pulling 94234ee on python-3.12-ci
into 0ecf4a8 on master.

@EwoutH EwoutH marked this pull request as ready for review November 17, 2023 12:56
@EwoutH EwoutH requested a review from quaquel November 17, 2023 12:57
@EwoutH EwoutH added the ci label Nov 17, 2023
@EwoutH EwoutH added this to the 2.5.0 milestone Nov 17, 2023
Copy link
Owner

@quaquel quaquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should test_evaluators be part of this. otherwise fine.

@EwoutH
Copy link
Collaborator Author

EwoutH commented Nov 17, 2023

I will keep the separate commits when merging.

Add Python 3.12 to CI testing by switching all default jobs to 3.12. Python 3.9 to 3.11 is still tested.
This commit resolves an AttributeError in the test_ipyparallel_evaluator method of the TestEvaluators class. The error was caused by the use of a non-existent method called_once() on a mock object. The correct method, assert_called_once(), has been applied to ensure the proper assertion of the mocked method's call frequency. This change ensures the test aligns with the intended functionality and adheres to the correct usage of the unittest.mock library in Python.
@EwoutH EwoutH merged commit 94234ee into master Nov 17, 2023
@EwoutH EwoutH deleted the python-3.12-ci branch November 17, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants