Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using pct_change to implement the to_simple_returns() function for se… #132

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

myrmarachne
Copy link
Member

…ries and dataframes

@myrmarachne myrmarachne force-pushed the to_simple_dataframe_optimization branch from cf1accc to b32aed2 Compare November 3, 2023 10:24
@codecov-commenter
Copy link

Codecov Report

Merging #132 (b32aed2) into master (216e6d4) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   76.70%   76.81%   +0.10%     
==========================================
  Files         227      227              
  Lines        9068     9071       +3     
==========================================
+ Hits         6956     6968      +12     
+ Misses       2112     2103       -9     
Files Coverage Δ
qf_lib/containers/dataframe/prices_dataframe.py 100.00% <100.00%> (ø)
...b/containers/dataframe/simple_returns_dataframe.py 100.00% <100.00%> (ø)
qf_lib/containers/series/prices_series.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216e6d4...b32aed2. Read the comment docs.

@JmmCz JmmCz merged commit 5c0dd3d into master Nov 3, 2023
5 checks passed
@myrmarachne myrmarachne deleted the to_simple_dataframe_optimization branch November 6, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants