Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove io.quarkus:quarkus-jms-spi-deployment in build-parent #166

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

zhfeng
Copy link
Contributor

@zhfeng zhfeng commented Feb 17, 2023

No description provided.

@zhfeng zhfeng requested a review from turing85 February 17, 2023 15:31
@zhfeng
Copy link
Contributor Author

zhfeng commented Feb 17, 2023

@turing85 I'd like to do a new release of 2.x after merge this PR. WDYT?

@turing85
Copy link
Contributor

@turing85 I'd like to do a new release of 2.x after merge this PR. WDYT?

@zhfend ythis is fine by me, yes. We should, however, create a ticket, so we do not forget to upstream the fix when the fix is done in 3.0.0.

@zhfeng
Copy link
Contributor Author

zhfeng commented Feb 17, 2023

Yeah, I raise a ticket for remvoing this dependency when Quarkus 3.0.0 has a new release.

@zhfeng zhfeng merged commit 6aa1b31 into quarkiverse:2.x Feb 17, 2023
@turing85
Copy link
Contributor

@zhfeng quarkus-artemis 2.0.5 has been released.

@zhfeng
Copy link
Contributor Author

zhfeng commented Feb 22, 2023

@turing85 Well, this new release is not backwards compatible because we change to use ConnectionFactoryWrapperBuildItem in quarkus-jms-spi-deployment. I wonder if we can bump to 2.1.0 at lease?

@turing85
Copy link
Contributor

turing85 commented Feb 22, 2023

@zhfeng hmm... yes we can. But... I cannot undo what I have done, i.e. 2.0.5 will stay broken. Maybe:

  • rollback the changes,
  • do a 2.0.6 release,
  • roll back the rollback, and
  • do a 2.1.0 release?

@turing85
Copy link
Contributor

turing85 commented Feb 22, 2023

@zhfeng In the mean time, I updated the release notes for version 2.0.5 and added the breaking change.

@zhfeng
Copy link
Contributor Author

zhfeng commented Feb 22, 2023

Thanks @turing85 and IMO, it could be good to just release 2.1.0 and no 2.0.x anymore. @gastaldi we met this backwards compatible issue and just wonder what is the best way from the maintenance perspective?

@zhfeng
Copy link
Contributor Author

zhfeng commented Feb 22, 2023

I have a similar issue with quarkus-pooled-jms and include un-compatible commit in a new release 1.0.9 😢

@turing85
Copy link
Contributor

turing85 commented Feb 22, 2023

@zhfeng okay, building 2.1.0 right now 👍

@turing85 turing85 added the docs Improvements or additions to documentation label Feb 22, 2023
@turing85 turing85 added maintenance and removed docs Improvements or additions to documentation labels Feb 22, 2023
@turing85
Copy link
Contributor

@zhfeng quarkus-artemis version 2.1.0 has been released.

@gastaldi
Copy link
Member

Thanks @turing85 and IMO, it could be good to just release 2.1.0 and no 2.0.x anymore. @gastaldi we met this backwards compatible issue and just wonder what is the best way from the maintenance perspective?

You could have a 2.0.x branch and release independently if you want,but I don't know if it's worth the effort

@middagj
Copy link
Contributor

middagj commented Feb 22, 2023

Let's wait until someone asks for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants