AsyncAPI v3 #184
Merged
AsyncAPI v3 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fjtirado |
|
@ChMThiel Ok, let me do a PR over this PR (reenable and change), once merged I will release |
|
Fixes #182 |
|
@fjtirado Please see Bug in asyncapi-core |
|
@ChMThiel Then I think the wisest path is to not merge this till the new release is available. Im currently working on the PR over your PR for the config part... |
[Fix #182] Update to 3.0 version
|
@fjtirado now we have to wait for the release of asyncapi-core.... |
fjtirado
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @fjtirado,
I updated the dependency in root-pom for
version.asyncapi.coreto 1.0.0-RC and made the necessary changes in ,y Scanner-modules.To be able to compile & test my changes, i temporarily disabled your modules by documenting the module in the root-pom:
Please have a look and at your part of the code to make it AsyncAPI v3 compliant.
What do you think - should we make a new release when you're finished ? It's a breaking change...so it might be a step to v1.0.0.
Best regards,
Christian