Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid publishing support modules in Maven Central #1499

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

gastaldi
Copy link
Member

@gastaldi gastaldi commented Sep 9, 2024

@gastaldi gastaldi requested a review from a team September 9, 2024 18:51
Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quarkus CXF is a Platform member, due to which the integration test modules incl. test jars are needed for testing the Platform.

Were those Central rules introduced recently?

Our docs module actually has a bytecode jar, source jar, because there is application.properties. The only missing part is JavaDoc, which could be added by adding a fake Java source file.

@gastaldi
Copy link
Member Author

gastaldi commented Sep 10, 2024

Quarkus CXF is a Platform member, due to which the integration test modules incl. test jars are needed for testing the Platform.

Ok, I updated the PR to keep it.

Were those Central rules introduced recently?

That's explained in https://central.sonatype.org/publish/requirements/#supply-javadoc-and-sources and JReleaser (the tool we'll use to push to Central) follows it rigorously to be able to publish to Central

Our docs module actually has a bytecode jar, source jar, because there is application.properties. The only missing part is JavaDoc, which could be added by adding a fake Java source file.

The docs module isn't referenced anywhere, and I believe adding a fake Java source file just so it's published in central is pointless.

@ppalaga ppalaga merged commit 53923a3 into main Sep 10, 2024
24 checks passed
@ppalaga ppalaga deleted the move_docs_module branch September 10, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants