Limit client generation to only those portTypes that are actually used #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
famod
commented
Jul 1, 2021
deployment/src/main/java/io/quarkiverse/cxf/deployment/QuarkusCxfProcessor.java
Show resolved
Hide resolved
|
I forgot to push a new test, will do ASAP. |
famod
commented
Jul 1, 2021
...ment/src/test/java/io/quarkiverse/cxf/deployment/test/CxfClientConstructorInjectionBean.java
Outdated
Show resolved
Hide resolved
dufoli
reviewed
Jul 1, 2021
deployment/src/main/java/io/quarkiverse/cxf/deployment/QuarkusCxfProcessor.java
Outdated
Show resolved
Hide resolved
deployment/src/main/java/io/quarkiverse/cxf/deployment/QuarkusCxfProcessor.java
Outdated
Show resolved
Hide resolved
deployment/src/main/java/io/quarkiverse/cxf/deployment/QuarkusCxfProcessor.java
Outdated
Show resolved
Hide resolved
deployment/src/main/java/io/quarkiverse/cxf/deployment/QuarkusCxfProcessor.java
Show resolved
Hide resolved
deployment/src/main/java/io/quarkiverse/cxf/deployment/QuarkusCxfProcessor.java
Show resolved
Hide resolved
deployment/src/main/java/io/quarkiverse/cxf/deployment/QuarkusCxfProcessor.java
Show resolved
Hide resolved
|
I pushed a separate commit to make reviewing easier. Will squash it once review is done. |
|
@shumonsharif can you review as well, please? Thanks! |
|
It is OK for me. |
@famod @dufoli Apologies for being MIA - I am reviewing now! |
shumonsharif
reviewed
Jul 2, 2021
There was a problem hiding this comment.
@famod Looks good to me, but just had a couple questions ... and readability is certainly massively improved with everything you touched! Thanks so much.
deployment/src/main/java/io/quarkiverse/cxf/deployment/QuarkusCxfProcessor.java
Show resolved
Hide resolved
deployment/src/main/java/io/quarkiverse/cxf/deployment/QuarkusCxfProcessor.java
Show resolved
Hide resolved
Resolves #252 Includes some cleanups and refactorings to QuarkusCxfProcessor. Also introduces tests that check constructor and instance injection.
|
I have just squashed the two commits. |
shumonsharif
approved these changes
Jul 2, 2021
|
LGTM ? |
|
and even release ;-) |
|
Sounds good @dufoli ... I'm on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #252
Includes some cleanups and refactorings to QuarkusCxfProcessor.
Also introduces tests that check constructor and instance injection.
A general note: I tried to reduce the number of local variables in the processor to make the code more readable (IMO).