Skip to content

Commit

Permalink
set node v18.16.0 to install by default (#384)
Browse files Browse the repository at this point in the history
  • Loading branch information
shivam-sharma7 authored Jun 16, 2023
1 parent 90c8d14 commit a9818ba
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@ public class QuinoaPackageManagerInstallTest {
@RegisterExtension
static final QuarkusUnitTest config = QuinoaQuarkusUnitTest.create(NAME).toQuarkusUnitTest()
.overrideConfigKey("quarkus.quinoa.package-manager-install", "true")
.overrideConfigKey("quarkus.quinoa.package-manager-install.node-version", "16.17.0")
.overrideConfigKey("quarkus.quinoa.package-manager-install.node-version", "18.16.0")
.overrideConfigKey("quarkus.quinoa.package-manager-install.install-dir", INSTALL_DIR)
.assertLogRecords(l -> {
assertThat(l)
.anyMatch(s -> s.getMessage().equals("Running Quinoa package manager build command: %s") &&
((String) s.getParameters()[0])
.endsWith(computeBinary(INSTALL_DIR) + " run build"));
assertThat(l)
.anyMatch(s -> s.getMessage().equals("v16.17.0"));
.anyMatch(s -> s.getMessage().equals("v18.16.0"));
});

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ public class QuinoaPackageManagerInstallWithSpaceTest {
@RegisterExtension
static final QuarkusUnitTest config = QuinoaQuarkusUnitTest.create(NAME).toQuarkusUnitTest()
.overrideConfigKey("quarkus.quinoa.package-manager-install", "true")
.overrideConfigKey("quarkus.quinoa.package-manager-install.node-version", "16.17.0")
.overrideConfigKey("quarkus.quinoa.package-manager-install.node-version", "18.16.0")
.overrideConfigKey("quarkus.quinoa.package-manager-install.install-dir", INSTALL_DIR)
.assertLogRecords(l -> {
assertThat(l)
.anyMatch(s -> s.getMessage().equals("Running Quinoa package manager build command: %s") &&
((String) s.getParameters()[0])
.endsWith(computeBinary(INSTALL_DIR) + " run build"));
assertThat(l)
.anyMatch(s -> s.getMessage().equals("v16.17.0"));
.anyMatch(s -> s.getMessage().equals("v18.16.0"));
});

@Test
Expand Down

0 comments on commit a9818ba

Please sign in to comment.