Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to vite codestart and improve dev-server host resiliency #380

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

ia3andy
Copy link
Collaborator

@ia3andy ia3andy commented Jun 14, 2023

  1. Switch to Vite for the codestart (it is not trivial as the codestart need to be on /quinoa.html)
  2. Improve the dev-server resiliency by checking if the server is using ipv6 or ipv4

The 2. is making vite work without any host option.

@ia3andy ia3andy requested a review from melloware June 14, 2023 10:53
Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactor!

@ia3andy
Copy link
Collaborator Author

ia3andy commented Jun 14, 2023

@melloware I would be nice if you could add a small section in the doc about the framework auto-detection and the supported frameworks (in another PR)

@melloware
Copy link
Contributor

Absolutely I will update the docs!

@ia3andy ia3andy merged commit 0577446 into quarkiverse:main Jun 14, 2023
@melloware
Copy link
Contributor

Did my best... 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants