Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.5 Release #382

Merged
merged 1 commit into from
Jun 14, 2023
Merged

2.0.5 Release #382

merged 1 commit into from
Jun 14, 2023

Conversation

melloware
Copy link
Contributor

2.0.5 Release

@melloware melloware requested a review from ia3andy June 14, 2023 14:28
Copy link
Collaborator

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melloware melloware merged commit 90c8d14 into main Jun 14, 2023
@melloware melloware deleted the 2-0-5 branch June 14, 2023 15:00
@shivarm
Copy link
Member

shivarm commented Jun 14, 2023

@melloware have you any plan for quinoa 1.2.x release?

@melloware
Copy link
Contributor Author

have their been any changes? I am not backporting all these major changes to the 1.X branch just minor bugfixes...

@shivarm
Copy link
Member

shivarm commented Jun 15, 2023

@melloware If I want to add feature for any other's framework where should i start in code base. most of the package manager configured so I think we need to integret only framework if I'm not wrong?

@melloware
Copy link
Contributor Author

I think you just need to add another entry here in this enum...

REACT("build", "start", 3000, Set.of("react-scripts", "react-app-rewired", "craco")),
VITE("dist", "dev", 5173, Set.of("vite")),
NEXT("out", "dev", 3000, Set.of("next")),
ANGULAR("dist/%s", "start", 4200, Set.of("ng")),
WEB_COMPONENTS("dist", "start", 8003, Set.of("web-dev-server"));

@shivarm
Copy link
Member

shivarm commented Jun 15, 2023

Then I want to add svelte, what would you say?

@melloware
Copy link
Contributor Author

I don't think you need a Svelte one here is a Svelte example using Vite!

vite.zip

just run mvn quarkus:dev and check it out!

@shivarm
Copy link
Member

shivarm commented Jun 15, 2023

@shivarm
Copy link
Member

shivarm commented Jun 15, 2023

got an error

shivamsharma@shivam:/mnt/c/Users/shivam sharma/Downloads/vite$  mvn quarkus:dev
[INFO] Scanning for projects...
[INFO]
[INFO] --------------------< org.acme:vite-svelte-quinoa >---------------------
[INFO] Building vite-svelte-quinoa 1.0.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- quarkus-maven-plugin:3.0.1.Final:dev (default-cli) @ vite-svelte-quinoa ---
[INFO] Invoking org.apache.maven.plugins:maven-resources-plugin:2.6:resources @ vite-svelte-quinoa
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Invoking io.quarkus:quarkus-maven-plugin:3.0.1.Final:generate-code @ vite-svelte-quinoa
[INFO] Invoking org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile @ vite-svelte-quinoa
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 1 source file to /mnt/c/Users/shivam sharma/Downloads/vite/target/classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  5.076 s
[INFO] Finished at: 2023-06-15T22:18:27+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:3.0.1.Final:dev (default-cli) on project vite-svelte-quinoa: Fatal error compiling: error: release version 17 not supported -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

@melloware
Copy link
Contributor Author

melloware commented Jun 15, 2023

yeah its saying it needs JDK17 release version 17 not supported

@shivarm
Copy link
Member

shivarm commented Jun 15, 2023

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants