Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plus sign look better in dark/light theme #390

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Plus sign look better in dark/light theme #390

merged 1 commit into from
Jun 27, 2023

Conversation

melloware
Copy link
Contributor

This makes the + sign on the ReadME look better in both light and dark theme

@shivarm
Copy link
Member

shivarm commented Jun 21, 2023

@melloware why build is failing?

@shivarm
Copy link
Member

shivarm commented Jun 21, 2023

@melloware why build is failing? I think you should try npm install then force push

@melloware
Copy link
Contributor Author

I have no idea why it's failing?

@shivarm
Copy link
Member

shivarm commented Jun 21, 2023

Np, this is docs related changes so we can skip this

shivarm
shivarm approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@shivarm shivarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@melloware melloware requested a review from ia3andy June 23, 2023 13:48
@melloware melloware added the documentation Improvements or additions to documentation label Jun 23, 2023
@ia3andy
Copy link
Collaborator

ia3andy commented Jun 27, 2023

I've restarted the CI

ia3andy
ia3andy approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ia3andy ia3andy merged commit f391bfe into quarkiverse:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

@shivarm shivarm shivarm approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melloware @shivarm @ia3andy