Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download node 18.18.0 LTS #510

Merged
merged 1 commit into from
Sep 20, 2023
Merged

download node 18.18.0 LTS #510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deployment/src/test/java/io/quarkiverse/quinoa/test/QuinoaPackageManagerInstallTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@ public class QuinoaPackageManagerInstallTest {
@RegisterExtension
static final QuarkusUnitTest config = QuinoaQuarkusUnitTest.create(NAME).toQuarkusUnitTest()
.overrideConfigKey("quarkus.quinoa.package-manager-install", "true")
.overrideConfigKey("quarkus.quinoa.package-manager-install.node-version", "18.17.0")
.overrideConfigKey("quarkus.quinoa.package-manager-install.node-version", "18.18.0")
.overrideConfigKey("quarkus.quinoa.package-manager-install.install-dir", INSTALL_DIR)
.assertLogRecords(l -> {
assertThat(l)
.anyMatch(s -> s.getMessage().equals("Running Quinoa package manager build command: %s") &&
((String) s.getParameters()[0])
.endsWith(computeBinary(INSTALL_DIR) + " run build"));
assertThat(l)
.anyMatch(s -> s.getMessage().equals("v18.17.0"));
.anyMatch(s -> s.getMessage().equals("v18.18.0"));
});

@Test
Expand Down
4 changes: 2 additions & 2 deletions ...nt/src/test/java/io/quarkiverse/quinoa/test/QuinoaPackageManagerInstallWithSpaceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ public class QuinoaPackageManagerInstallWithSpaceTest {
@RegisterExtension
static final QuarkusUnitTest config = QuinoaQuarkusUnitTest.create(NAME).toQuarkusUnitTest()
.overrideConfigKey("quarkus.quinoa.package-manager-install", "true")
.overrideConfigKey("quarkus.quinoa.package-manager-install.node-version", "18.17.0")
.overrideConfigKey("quarkus.quinoa.package-manager-install.node-version", "18.18.0")
.overrideConfigKey("quarkus.quinoa.package-manager-install.install-dir", INSTALL_DIR)
.assertLogRecords(l -> {
assertThat(l)
.anyMatch(s -> s.getMessage().equals("Running Quinoa package manager build command: %s") &&
((String) s.getParameters()[0])
.endsWith(computeBinary(INSTALL_DIR) + " run build"));
assertThat(l)
.anyMatch(s -> s.getMessage().equals("v18.17.0"));
.anyMatch(s -> s.getMessage().equals("v18.18.0"));
});

@Test
Expand Down
2 changes: 1 addition & 1 deletion docs/modules/ROOT/pages/index.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ Quinoa can be configured to install NodeJS and NPM in the project directory:
[source,properties]
----
quarkus.quinoa.package-manager-install=true <1>
quarkus.quinoa.package-manager-install.node-version=18.17.0 <2>
quarkus.quinoa.package-manager-install.node-version=18.18.0 <2>
----

<1> Enable package manager install
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
%angular.quarkus.quinoa.ignored-path-prefixes=/q,/bar/foo/baz
%angular.quarkus.quinoa.package-manager-install=true
%angular.quarkus.quinoa.package-manager-install.install-dir=target/
%angular.quarkus.quinoa.package-manager-install.node-version=18.17.0
%angular.quarkus.quinoa.package-manager-install.node-version=18.18.0
%lit.quarkus.quinoa.ui-dir=src/main/ui-lit
%lit.quarkus.quinoa.build-dir=dist
%lit.quarkus.quinoa.index-page=app.html
Expand Down
2 changes: 1 addition & 1 deletion runtime/src/main/codestarts/quarkus/quinoa-codestart/base/src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ quarkus:
quinoa:
package-manager-install:
~: true
node-version: 18.17.0
node-version: 18.18.0