Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node.js install retry (5) #514

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Add Node.js install retry (5) #514

merged 1 commit into from
Sep 22, 2023

Conversation

ia3andy
Copy link
Collaborator

@ia3andy ia3andy commented Sep 22, 2023 •
edited
Loading

melloware
melloware approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it. I wish they would fix that bug with that plugin though too!

@melloware
Copy link
Contributor

I have another bug I am running into with Vite I will try and create a reproducer and report in another issue once I figure out what is going on.

@ia3andy
Copy link
Collaborator Author

ia3andy commented Sep 22, 2023

I love it. I wish they would fix that bug with that plugin though too!

Better not wait for them, we have control :)

@ia3andy
Copy link
Collaborator Author

ia3andy commented Sep 22, 2023

I have another bug I am running into with Vite I will try and create a reproducer and report in another issue once I figure out what is going on.

is this a new bug? with the latest changes?

@melloware
Copy link
Contributor

No its happening with the current 2.1.0 version of hte plugin. The WebSocket is getting closed whenever i make any Java changes I see the server hot reload but then the UI is dead with Quinoa saying it can't forwrard the message. I will write it up with a reproducer.

@ia3andy ia3andy merged commit afe1661 into quarkiverse:main Sep 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First start shows no log while waiting for NodeJS DL
2 participants
@ia3andy @melloware