Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update advanced-guides.adoc #562

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Update advanced-guides.adoc #562

merged 1 commit into from
Nov 3, 2023

Conversation

melloware
Copy link
Contributor

Describe your changes

testing using Vite I realized that it was not allowing boomarkable URLs to my app location /app

Working with @ia3andy we realized these two values needed to change

  1. Add /@ because Vite requests two things /@vite/client and /@reactrefresh which were being blocked by default.
  2. The file regex URL needed to be tweaked.

@melloware melloware requested a review from ia3andy November 2, 2023 16:53
@melloware melloware added the documentation Improvements or additions to documentation label Nov 2, 2023
@ia3andy ia3andy merged commit 49228a5 into main Nov 3, 2023
@ia3andy ia3andy deleted the melloware-advanced-guide branch November 3, 2023 13:20
@ia3andy
Copy link
Collaborator

ia3andy commented Nov 3, 2023

Maybe it would make sense to add the @ in dev mode only there:
https://github.com/quarkiverse/quarkus-quinoa/blob/main/deployment/src/main/java/io/quarkiverse/quinoa/deployment/config/QuinoaConfig.java#L149

@melloware
Copy link
Contributor Author

Let me submit a PR.

@ia3andy
Copy link
Collaborator

ia3andy commented Nov 3, 2023

Let me submit a PR.

to try it you need RR and Quinoa with Vite I guess?

@melloware
Copy link
Contributor Author

yep it seems specific to Vite when trying to use SPA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy Awaiting requested review from ia3andy

Assignees

@ia3andy ia3andy

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melloware @ia3andy