Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NextJS 14 next export has been removed #572

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

shivam-sharma7
Copy link
Member

@shivam-sharma7 shivam-sharma7 commented Nov 25, 2023

@shivam-sharma7 shivam-sharma7 marked this pull request as draft November 25, 2023 14:34
@melloware
Copy link
Contributor

I think we need to update the docs too: https://docs.quarkiverse.io/quarkus-quinoa/dev/web-frameworks.html#nextjs-config

and test it. Someone else on another forum I am on was saying Next14 doesn't generate an index.html like the old export did which Quinoa needs?

@shivam-sharma7 shivam-sharma7 force-pushed the patch-2 branch 2 times, most recently from 01968ac to f6a9c56 Compare December 1, 2023 14:48
@shivam-sharma7 shivam-sharma7 marked this pull request as ready for review December 1, 2023 14:48
@shivam-sharma7 shivam-sharma7 force-pushed the patch-2 branch 2 times, most recently from f69135d to 3637f09 Compare December 2, 2023 14:43
@melloware
Copy link
Contributor

melloware commented Dec 4, 2023

@shivam-sharma7 does next generate an index.html without next export now?

Don't we need to check for the existence of "output": "export" or fail?

@melloware melloware added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Dec 4, 2023
@shivam-sharma7
Copy link
Member Author

shivam-sharma7 commented Dec 5, 2023

the next export command is deprecated in Next.js 14. Starting with this version, we should use the "output": "export" option in your next.config.js file to generate static exports.

Here is an example of my merged PR- https://github.com/tailwarden/komiser/pull/1217/files

@melloware
Copy link
Contributor

Yes so we need to update the docs for Next.JS or check for the output: export and throw an error if not found.

Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@melloware
Copy link
Contributor

When I tried this before Quinoa does NOT work unless its in this mode so we have to check and make it required for Next. You can't use Next with Quinoa without the static export mode.

@shivam-sharma7 shivam-sharma7 force-pushed the patch-2 branch 2 times, most recently from d36af64 to 81c3034 Compare December 6, 2023 00:45
@melloware melloware merged commit e97d351 into quarkiverse:main Dec 8, 2023
2 checks passed
@shivam-sharma7 shivam-sharma7 deleted the patch-2 branch December 10, 2023 15:20
@melloware melloware added this to the 2.3.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next 14 Support
2 participants