Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Critical] Make sure the devServer indexPage is only used in dev mode #607

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

ia3andy
Copy link
Collaborator

@ia3andy ia3andy commented Jan 5, 2024

Fixes #603

This is a big issue which could affect production on different kind of apps (not only with Next), it should be backported.

To mitigate this issue:

  • if not set (Optional), the dev server index page name is not used, only Next framework automatically overrides it (leading to the production startup failing).
  • If set (this is a new and not very commonly used config) , then currently the dev server index page name would be used in production leading to either a startup failing or a 404 on the index page

@ia3andy ia3andy merged commit 4f69298 into quarkiverse:main Jan 5, 2024
2 checks passed
ia3andy added a commit that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NextJS - Failed to start Quarkus
1 participant